Skip to content

avoid printing env vars conflict warnings if there is no conflict #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lionello merged 2 commits into from
Jan 19, 2026
Merged

avoid printing env vars conflict warnings if there is no conflict #1807

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6084549
avoid printing env vars conflict warnings if there is no conflict
jordanstephens Jan 19, 2026
0bae8bc
fix false positives on missing envs
lionello Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/pkg/stacks/stacks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,19 +216,21 @@ func ReadInDirectory(workingDirectory, name string) (*Parameters, error) {
// This was basically ripped out of godotenv.Overload/Load. Unfortunately, they don't export
// a function that loads a map[string]string, so we have to reimplement it here.
func LoadStackEnv(params Parameters, overload bool) error {
currentEnv := map[string]bool{}
currentEnv := map[string]string{}
rawEnv := os.Environ()
for _, rawEnvLine := range rawEnv {
key := strings.Split(rawEnvLine, "=")[0]
currentEnv[key] = true
key, value, found := strings.Cut(rawEnvLine, "=")
if found {
currentEnv[key] = value
}
}

paramsMap := params.ToMap()
for key, value := range paramsMap {
if currentEnv[key] && !overload {
term.Warnf("The variable %q is set in both the stack file and the environment. The value from the environment will be used.\n", key)
if envValue, ok := currentEnv[key]; ok && envValue != value && !overload {
term.Warnf("The variable %q is set in both the stack and the environment. The value from the environment will be used.\n", key)
}
if !currentEnv[key] || overload {
if _, ok := currentEnv[key]; !ok || overload {
err := os.Setenv(key, value)
if err != nil {
return fmt.Errorf("could not set env var %q: %w", key, err)
Expand Down
Loading