Skip to content

Comments

chore: remove unused QueryForDebug#1849

Merged
jordanstephens merged 1 commit intomainfrom
lio/remove-queryfordebug
Jan 22, 2026
Merged

chore: remove unused QueryForDebug#1849
jordanstephens merged 1 commit intomainfrom
lio/remove-queryfordebug

Conversation

@lionello
Copy link
Member

@lionello lionello commented Jan 22, 2026

Description

new agent uses existing QueryLogs function so QueryForDebug is no longer used.

Linked Issues

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

Summary by CodeRabbit

  • Chores
    • Removed debug query functionality from CLI provider implementations.

✏️ Tip: You can customize this high-level summary in your review settings.

new agent uses existing QueryLogs function.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

The PR systematically removes the QueryForDebug method and related debugging functionality from the Provider interface and all its implementations (AWS BYOC, DigitalOcean BYOC, GCP BYOC, and Playground), eliminating CloudWatch and logging query capabilities for AI debugging across all provider backends.

Changes

Cohort / File(s) Summary
Provider Interface & Implementations
src/pkg/cli/client/provider.go, src/pkg/cli/client/byoc/aws/byoc.go, src/pkg/cli/client/byoc/do/byoc.go, src/pkg/cli/client/byoc/gcp/byoc.go, src/pkg/cli/client/playground.go
Removes QueryForDebug method from Provider interface and all implementations. AWS removes CloudWatch log tailing logic and slices import. GCP removes helper methods createDeploymentLogQuery and query along with io import. DO and Playground remove stub implementations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • jordanstephens

Poem

🐰 The debug methods hopped away,
No more logs to tail and play,
CloudWatch whispers fade to none,
Provider interfaces, simply done! ✨
Cleaner code hops in the sun. 🌞

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove unused QueryForDebug' directly and clearly summarizes the main change: removal of the QueryForDebug method across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@jordanstephens jordanstephens merged commit 8ffbf56 into main Jan 22, 2026
14 checks passed
@jordanstephens jordanstephens deleted the lio/remove-queryfordebug branch January 22, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants