Stacks Cleanup

[jordanstephens]

Description

• Avoid reading from global.Stack when session.Stack is available
• Set options.RequireStack = true for deployments to force selection when interactive

Linked Issues

Checklist

• I have performed a self-review of my code
• I have added appropriate tests
• I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

Summary by CodeRabbit

• Bug Fixes
  • Stack configuration and mode now properly use active session context instead of global settings, improving multi-session workflow handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR shifts stack context sourcing from global to per-session references in the CLI command layer, updating stack mode propagation and initialization checks in cd.go and compose.go to use the active session stack instead of the global stack.

Changes

Cohort / File(s)	Summary
Stack Context Migration src/cmd/cli/command/cd.go, src/cmd/cli/command/compose.go	Replaced global stack references with session stack across the compose-up and cd flows. In cd.go, Mode source changed to session.Stack.Mode. In compose.go, added options.RequireStack = true, switched debugger initialization, mode propagation, and stack existence checks to use session.Stack instead of global.Stack.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Lio/fix default stack #1820: Directly modifies the same compose/cd flow to replace global stack references with session stack usage (e.g., session.Stack.Mode, session.Stack.Name).
• avoid ignoring missing stack error #1835: Shifts active stack sourcing logic from global.Stack to session.Stack and ensures stack-loading errors are propagated correctly.
• Onboard users to stacks during deployment #1700: Updates cd.go and compose.go to change how stack context is sourced and passed through the command layer.

Poem

🐰 Global stacks? Oh how they used to roam,
But now each session calls its stack back home,
Per-context references hop and play,
Building cleaner CLI logic today! 🌿✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Stacks Cleanup' is vague and does not clearly describe the specific changes made to the codebase. While related to stacks, it lacks specificity about the actual modifications (migrating from global.Stack to session.Stack).	Revise the title to be more specific, such as 'Migrate stack references from global to session context' or 'Use session.Stack instead of global.Stack for compose operations'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

level=warning msg="[linters_context] running gomodguard failed: unable to read module file go.mod: current working directory must have a go.mod file: if you are not using go modules it is suggested to disable this linter"
level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}