Skip to content

Comments

Reapply "Logs refactoring using Go iterators (#1845)"#1938

Open
lionello wants to merge 2 commits intomainfrom
lio/logs-iter
Open

Reapply "Logs refactoring using Go iterators (#1845)"#1938
lionello wants to merge 2 commits intomainfrom
lio/logs-iter

Conversation

@lionello
Copy link
Member

@lionello lionello commented Feb 19, 2026

Description

This reverts commit 0ebd3d7, reapplying #1845

Linked Issues

Need to check the AWS/GCP issues that happened in MVP deployment here: https://github.com/DefangLabs/defang-mvp/actions/runs/22189428489

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lio/logs-iter

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jordanstephens
Copy link
Member

For the record, I just confirmed that @edw-defang 's fix here resolved the issue I saw earlier this week when deploying to GCP

@lionello lionello marked this pull request as ready for review February 23, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants