Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe pull request introduces per-CD-operation etag handling in BYOC AWS and DO client implementations. An etag field is added to cdCommand structs and threaded through CD command construction, deployment flows, and log retrieval operations, with the etag propagated via environment variable. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)level=warning msg="[linters_context] running gomodguard failed: unable to read module file go.mod: current working directory must have a go.mod file: if you are not using go modules it is suggested to disable this linter" Comment |
Description
GCP was already using
DEFANG_ETAGso doing the same for AWS and DO.Linked Issues
Checklist
Summary by CodeRabbit