Skip to content

Comments

No Merge Require - support prompt in authorize#7

Open
KevyVo wants to merge 2 commits intomasterfrom
kevin/prompt
Open

No Merge Require - support prompt in authorize#7
KevyVo wants to merge 2 commits intomasterfrom
kevin/prompt

Conversation

@KevyVo
Copy link

@KevyVo KevyVo commented Feb 10, 2026

There is not prompt field in the AuthorizationState by allowing this we are able to do the following.

The openauth package doesn't forward the prompt parameter from our app to GitHub. So when we tell it "hey, ask the user for consent again," it just ignores us and does a normal login.

We need two small plumbing changes inside openauth to pass prompt through:

  1. issuer.ts — when our app sends /authorize?prompt=consent, the issuer needs to read it and forward it to the provider's
    internal /github/authorize?prompt=consent route
  2. oauth2.ts — the provider needs to read it and put it on the actual GitHub URL:
    https://github.com/login/oauth/authorize?...&prompt=consent

Without both, the prompt=consent gets dropped along the way and GitHub never sees it.

This PR will solve this. There was PR in portal related to this: https://github.com/DefangLabs/portal/pull/484.

There no need to merge this PR unless we want to sync the Git subtree.

@KevyVo KevyVo requested review from lionello and raphaeltm February 10, 2026 20:06
@KevyVo KevyVo self-assigned this Feb 10, 2026
@KevyVo KevyVo added the enhancement New feature or request label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant