Support more JSON RPCs for Hedera #2001
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
A similar PR was rejected last time with no explanation - please share comment if this is also to be rejected |
Define101
reviewed
Sep 12, 2025
|
Validation failed for chain files. Please check the workflow logs for details. Error message: |
Removed validationcloud tracking details from RPC configurations.
Author
|
@Define101 please can you review? |
Member
|
@jaycoolslm rpcs must be public. No api keys ${THIRDWEB_API_KEY} |
Removed thirdweb RPC URLs from mainnet and testnet configurations.
Author
Okay... many other examples in the file which have API keys. LGTM |
Author
|
Please re-review @Define101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are adding a new RPC, please answer the following questions.
Link the service provider's website (the company/protocol/individual providing the RPC):
Provide a link to your privacy policy:
Your RPC should always be added at the end of the array.