Update from upstream repo kwsch/PKHeX#1
Open
backstroke-bot wants to merge 8055 commits intoDelphox:masterfrom
Open
Update from upstream repo kwsch/PKHeX#1backstroke-bot wants to merge 8055 commits intoDelphox:masterfrom
backstroke-bot wants to merge 8055 commits intoDelphox:masterfrom
Conversation
kwsch
force-pushed
the
master
branch
2 times, most recently
from
e13acf3 to
6bed33f
Compare
kwsch
force-pushed
the
master
branch
3 times, most recently
from
0c4f92a to
9ef9355
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
a730ac5 to
6e9f230
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
bfccdae to
fbb9e0b
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
c460f5b to
ecee948
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
fcadbda to
2bbd767
Compare
kwsch
force-pushed
the
master
branch
3 times, most recently
from
81c04d8 to
5d5d913
Compare
Previously allowed cells and allowed multiple to be selected, resulting in some issues if users selected multiple cells and tried to trigger an open via contextmenu opening.
https: //github.com//pull/4735#issuecomment-3986152531 Co-Authored-By: Carbonara <108797333+Mimigris@users.noreply.github.com>
Allow EntitySearchSetup to be translated (rearrange the initialization, no need to retain/defer). Rename Gen9a's gender label (previously blacklisted as an "auto-updating" label). Other gender/Stat labels currently blacklisted in DevUtil probably need to get refactored to be enums/etc, but I currently lack the time/patience to understand those editors well enough to properly support the refactoring needed. json exports: add newline at end to match the default editorconfig settings and general convention. we don't want textfiles loading in as a string[] with an empty string last entry.
* Adjust gen 2 flag categories GSC: - Move bedroom accessories from * (UsefulFeature) to b (currently unassigned, but ideally a new category dedicated to bedroom accessories) C: - Move GS Ball flags from */r (Rebattle) to e (EventEncounter) - Move Odd Egg flag from r (Rebattle) to g (GiftAvailable) - Add missing Mystery Gift item line to the Japanese, Spanish, Korean and Chinese translations (untranslated) * Adjust RSFRLG event categories RS: - Move the HM 08 miss flag from Rebattle to StoryProgress - Move the Fossil flags from Rebattle to GiftAvailable - Move the Badges from UsefulFeature to StoryProgress - Move the Pokelot and S. S. Tidal constants from StoryProgress to Misc - Move the Professor Birch constant from Misc to StoryProgress FRLG: - Move the Lapras, Magikarp, Old Amber, Eevee, Trades and Fossil flags from Misc to GiftAvailable - Move the Shown Mystic & Aurora Ticket flags from Misc to EventEncounter Note: regular items were already classified into the nonexistent i section, keeping it for items - Make the Spanish, Simplified Chinese and Traditional Chinese use the same lines than the other languages. If the lines they had translated existed in the new format, or were close enough, I reused those lines, otherwise they will need to be retranslated. * Adjust E event categories Gen 3 E - Move Badges and Frontier Pass flags from UsefulFeature to StoryProgress - Move Hidden items flags from Rebattle to HiddenItem - Move Items flags from Rebattle to Item - Move don't spawn flags from Rebattle to Misc unless the current category makes sense - Move Items from Rebattle to Item - Move Pokelot & S. S. Tidal constants from StoryProgress to Misc - Move Professor Birch constant from Misc to StoryProgress * Adjust Spanish and Chinese E flags Same thing than with FRLG * Make the amount of lines be consistent + Fix a line jump typo in the French DP flags * Adjust remaining events Gen 4 DP: - Dialga/Palkia moved from StoryProgress to Rebattle - Hidden items moved from StoryProgress to HiddenItem - Items moved from StoryProgress to Item - Trendy phrase moved from StoryProgress to Useful Feature Gen 4 PT: - Hidden items moved from StoryProgress to HiddenItem - Items moved from StoryProgress to Item - Trendy phrase moved from StoryProgress to Useful Feature - Togepi moved from Rebattle to GiftAvailable Gen 4 HGSS: - Spiky-eared Pichu, Kanto Starters, Togepi Egg moved from Rebattle to GiftAvailable Gen 5 BW: - Zorua events moved from StoryProgress to EventEncounter - Daily Royal Unova & Fossil moved from StoryProgress to Useful feature - Darmanitan moved from GiftAvailable to Rebattle Gen 5 B2W2: - Daily Royal Unova & Fossil moved from StoryProgress to Useful feature Gen 6 XY: - Super Unlocked moved from Misc to Useful Feature - Statuette moved from Misc to Achievement Gen 6 ROSA: - Items moved from StoryProgress to Item
Remove GameSync/SecureValue from SAV tab (still lives in Block Data) Remove inaccessible items from FRLG/E key items
Also pass the tooltips to the components container so that they dispose of anything if needed too. A user had a long-running script/session that drag-dropped a few thousand times, which exhausted the Windows GDI handle limit (10,000 per process).
Render it manually rather than let controls be goofy with draw calls.
Some languages have localized these labels to long strings; previously they were truncated (probably frustrating); now, they all show (wrapped text is the best I can do -- better than truncating?)
Changed: Inventory editor no longer needs to clone the save file on GUI open Changed: some method signatures have moved from SAV3* to the specific block Allows the block structures to be used without a SAV3 object Allows the Inventory editor to open from a blank save file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
The remote
kwsch/PKHeXhas some new changes that aren't in this fork.So, here they are, ready to be merged! 🎉
If this pull request can be merged without conflict, you can publish your software
with these new changes. Otherwise, if you have merge conflicts, this
is the place to fix them.
Have fun! 👋
From,
🏊 Your Neighborly Backstroke Bot
PS. Hey, there's a new version of Backstroke available. If you'd like to configure repo-to-repo syncing or sync to all forks, check it out here.