Draft
Conversation
…ed operations mode of ZSF. Also made verbosity of logging optional.
…ity for the time-averaged mode.
…ted parameter name in comments.
…es are for development only.
…<level> in .ini general section to change.
…antity in relation to the profile.
… configured laterals.
…fferences (max 1cm), also made the delta_time check towards time steps and phase-wise phase lengths a bit more strict to prevent having corrected phase lenghts of 0, wich doesn't allow for any correction in a new phase.
…sea volumes are zero in phases where that door is closed.
… asserts elsewhere.
… not set in the csv.
…n cause discharge reversals.
…ies stepping. Also improved correction of first phase where the dimr update time step is initially unknown. Also fixed one-off error when stepping to new phases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains all the developments needed to link ZSF directly to D-Flow FM trough a BMI interface using DIMR.