Add ship volume to lake/sea to phase transports#5
Draft
jackvreeken wants to merge 1 commit intomasterfrom
Draft
Conversation
Contributor
jackvreeken
commented
May 3, 2023
jackvreeken
commented
- Check if Excel wrapper still works
- Add (Python) test for these new outputs
- Update commit message to elaborate a bit more on why this information is needed
- Update docs
- Express as volume, or as discharge? Other quantities are in discharge. I'd prefer discharge then, talk to Otto.
When a ship goes through a lock, water is displaced in the opposite direction. Depending on how a far-field model connected to the ZSF can model ships, it makes sense to either replace the displaced ship volume with water, some type of solid/local air pressure field, or flat out ignore it. Note that ignoring the ship displacement will lead to translation waves in many far-field models. Substituting the displaced ship volume with water is generally a lesser evil.
jackvreeken
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.