Merged
Conversation
symroe
approved these changes
Jan 31, 2018
|
|
||
|
|
||
| # import application constants | ||
| from .constants.needs_review import * # noqa |
Member
There was a problem hiding this comment.
E261 at least two spaces before inline comment
Member
|
The smallest of comments – it's not like that will be the only pep8 error in this codebase. Will merge anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've moved this to a
/settings/constantsdir. There is probably some further 'refactoring' we can do to separate app constants from stuff like DB credentials, context processors etc.This is probably out of date. We could look at automatically generating it. We also need to ensure we keep people we have manually added to this list for various reasons (e.g: previous vandalism incidents). It might also be worth looking at Move the LIABLE_TO_VANDALISM setting to the database mysociety/yournextrepresentative#997 where @mhl has done some work on moving this to the DB where it may be easier to maintian than a config file?
Closes #412