feat(allow-list): added a new parameter in both services to create an allow list for desired IPs be allowed and rest blocked

[rios0rios0]

No description provided.

[rios0rios0]

Is anyone available to review? @nscuro?

[nscuro]

Is there a way to support such customization without eventually copying the entire Service spec into our Helm chart? i.e. can we accept a generic object instead and embed it into the Service manifests somehow?

[rios0rios0]

Is there a way to support such customization without eventually copying the entire Service spec into our Helm chart? i.e. can we accept a generic object instead and embed it into the Service manifests somehow?

Sorry, I was just following the standard the community is following for helm charts and those kind of customization (SonarQube for example: https://github.com/SonarSource/helm-chart-sonarqube/blob/master/charts/sonarqube/values.yaml#L104). But I do agree with you that it seems to be duplicating. The only way I can think of improving that, would be passing the responsibility of creating the service code to the user who is using the chart. Like:

 {{- if .Values.apiServer.enabled }}
   {{- with .Values.apiServer.service }}
   {{- toYaml . | nindent 0 }}
   {{- end }}
 {{- end }}

Although, it's not that beautiful, and it does complicate the things in Terraform for example, which is the way I'm using this chart.

What are your thoughts on that?