Moved ServiceClient to its own set of files #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service.hpp and service_impl.hpp files were getting very long and unwieldy due to the large number of different classes they contained. The ServiceClient class in particular is the longest, and most often needs to be consulted by users since it defines the API clients interact with, so I moved it to its own set of header/impl files. Also, in a minor fix, removed a reference to the nonexistant service_server_api.hpp from the documentation comments at the top of service.hpp. This seems to refer to a much older design for Casacade (where there was something called an 'onData()' function on servers) and is confusing for users.
Contributor
Author
|
Compile check passes, and there are no code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service.hpp and service_impl.hpp files were getting very long and unwieldy due to the large number of different classes they contained. The ServiceClient class in particular is the longest, and most often needs to be consulted by users since it defines the API clients interact with, so I moved it to its own set of header/impl files.
This does not contain any code changes, just copying and pasting code from one file to another (and adding
#include "service_client.hpp"in a few places next to#include "service.hpp"), so it shouldn't require testing or review. I verified that the code still compiles with the new file structure.