Skip to content

Conversation

@HappyPaul55
Copy link
Contributor

This pull request updates the proxy configuration in manifest.json to support dynamic injection of authentication settings for Atlassian API requests. The main change is the addition of the settingsInjection field, which allows sensitive credentials and tokens to be injected into request headers or bodies as needed for different endpoints.

Proxy configuration enhancements:

  • Added settingsInjection for the https://auth.atlassian.com/.* endpoint, enabling injection of client_id and client_secret into the request body, and api_token into the header.
  • Updated the https://(.*).atlassian.net/.* and https://api.atlassian.com/.* endpoints to support injection of api_key and username into request headers via the new settingsInjection field.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the proxy configuration security by introducing the settingsInjection field to restrict where sensitive authentication settings can be injected. The changes limit token and credential replacements to specific headers or body fields for each Atlassian API endpoint, reducing potential security vulnerabilities.

Key changes:

  • Added settingsInjection configuration for three Atlassian endpoints to control where credentials can be injected
  • Reordered proxy whitelist entries (moved auth.atlassian.com to the top)
  • Restricted credential injection to specific locations (headers or body) per endpoint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants