[feature] SC-166737/improve app proxy security by restricting where token replacements can go #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken replacements can go
|
Build for commit 68d1dae deployed to: https://mondaycom-pr-54.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security for the Monday.com app integration by introducing automatic credential injection through a new settingsInjection configuration in the manifest. This approach restricts where sensitive tokens and credentials can be injected in outgoing API requests, improving the app's security posture.
- Added
settingsInjectionconfiguration to the Monday.com API proxy endpoint to automatically inject access tokens into the Authorization header - Added
settingsInjectionconfiguration to the OAuth token endpoint to automatically inject client credentials into the request body
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the API configuration in the
manifest.jsonfile to improve how sensitive settings are injected into outgoing requests. The main changes introduce a newsettingsInjectionfield for both the Monday.com API and OAuth token endpoints, enabling automatic injection of authentication and client credentials.API authentication improvements:
settingsInjectionfield to the Monday.com API configuration to automatically inject theaccess_tokeninto theAuthorizationheader for requests.OAuth credential handling enhancements:
settingsInjectionfield to the OAuth token endpoint configuration to automatically inject theclient_idandclient_secretinto the request body for authentication.