-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade Deps #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade Deps #56
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate runtime and development dependencies in package.json and pnpm-lock.yaml to newer minor/patch versions to keep the app, build, and test tooling current and compatible. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue, and left some high level feedback:
- Consider aligning the
jest-environment-jsdommajor version withjest(currently Jest 29 vs jsdom env 30), as mixing major versions can lead to subtle runtime or config incompatibilities. - Given the upgrade to TypeScript 5.9.3, double-check that the existing
ts-jestversion (27.1.5) still officially supports this TS/Jest combo, as olderts-jestreleases often lag behind newer TypeScript and Jest versions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider aligning the `jest-environment-jsdom` major version with `jest` (currently Jest 29 vs jsdom env 30), as mixing major versions can lead to subtle runtime or config incompatibilities.
- Given the upgrade to TypeScript 5.9.3, double-check that the existing `ts-jest` version (27.1.5) still officially supports this TS/Jest combo, as older `ts-jest` releases often lag behind newer TypeScript and Jest versions.
## Individual Comments
### Comment 1
<location> `package.json:50` </location>
<code_context>
"eslint-plugin-react-hooks": "4.3.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "^2.8.8",
"rollup-plugin-copy": "3.4.0",
</code_context>
<issue_to_address>
**issue (bug_risk):** The `jest-environment-jsdom` v30 range may not be compatible with Jest 29.x.
Since `jest-environment-jsdom` is usually versioned in sync with Jest, mixing 29.x Jest with a 30.x environment risks subtle test runtime or API incompatibilities. Consider either pinning `jest-environment-jsdom` to a 29.x range or upgrading Jest and related packages to 30.x together.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades several production dependencies and development tooling packages to their latest minor/patch versions. The changes focus on keeping the project current with security patches, bug fixes, and feature updates across core libraries, monitoring tools, and development dependencies.
Key changes:
- Core UI library and React ecosystem packages updated to latest versions
- Sentry monitoring tools upgraded for improved error tracking
- Development tooling (TypeScript, Vite, Jest, SWC) updated to newer versions
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates version specifiers for 13 dependencies including core UI, Sentry, React Query, build tools, and type definitions |
| pnpm-lock.yaml | Comprehensive lockfile update reflecting all transitive dependency changes from the package.json updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 1e0bfc4 deployed to: https://surveymonkey-pr-56.ci.next.deskprodemo.com URLs: |
This pull request updates several dependencies and devDependencies in the
package.jsonfile to their latest versions. These upgrades primarily focus on keeping the project up to date with security patches, bug fixes, and new features.Dependency updates:
@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@tanstack/react-query, andreact-router-domto their latest versions.Development tooling updates:
@swc/core,@types/react,jest-environment-jsdom,styled-components,typescript, andviteto newer versions for improved performance and compatibility.Summary by Sourcery
Update application and tooling dependencies to newer versions to keep the project current and compatible with the surrounding ecosystem.
Build: