Upgrade Deps #60
Open
Upgrade Deps #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrade runtime and development dependencies in package.json to newer minor and patch versions, updating the lockfile accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:64` </location>
<code_context>
"react-resize-observer": "^1.1.1",
"rollup-plugin-copy": "3.4.0",
"slugify": "^1.6.6",
"ts-jest": "^27.1.5",
- "typescript": "^5.8.3",
- "vite": "^6.3.6"
</code_context>
<issue_to_address>
**issue (bug_risk):** ts-jest v27 may not be compatible with Jest 29 and TypeScript 5.9, which can cause test compilation/runtime issues.
With Jest at ^29.7.0 and TypeScript at ^5.9.3, ^27.1.5 of ts-jest may be out of its supported range and lead to transformer/diagnostics issues and flaky tests. Please check the ts-jest compatibility matrix and align its version with your Jest and TypeScript versions to avoid miscompiled or intermittently failing tests.
</issue_to_address>
### Comment 2
<location> `package.json:58-59` </location>
<code_context>
"intersection-observer": "^0.12.2",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "2.8.7",
"react-resize-observer": "^1.1.1",
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Using jest-environment-jsdom v30 with Jest v29 can introduce version-mismatch issues.
The environment package is now a major version ahead of Jest (^29.7.0 vs ^30.2.0). This mismatch can cause subtle, hard-to-debug issues if Jest’s internal APIs change. Consider either upgrading Jest to v30 or pinning jest-environment-jsdom to a version known to support Jest 29.
```suggestion
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request upgrades multiple dependencies in package.json to their latest minor and patch versions. The updates include production dependencies like @deskpro/app-sdk, @sentry/react, @tanstack/react-query, react-hook-form, react-router-dom, and styled-components, as well as development dependencies including @swc/core, @types/react, jest-environment-jsdom, typescript, and vite.
Key changes:
- Production dependencies updated to newer minor/patch versions for improved features and bug fixes
- Development dependencies including TypeScript (5.8.3 → 5.9.3) and Vite (6.3.6 → 6.4.1) updated
- Testing infrastructure updated with jest-environment-jsdom and related packages
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated dependency versions for both production and development packages |
| pnpm-lock.yaml | Updated lockfile with resolved dependencies and their transitive dependencies |
Based on my review of the changes, all dependency updates appear to be valid minor or patch version upgrades. The versions specified exist and are appropriate. The lockfile changes are consistent with the package.json updates, showing proper resolution of all transitive dependencies. No issues were found with this dependency upgrade.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 4166052 deployed to: https://toggl-pr-60.ci.next.deskprodemo.com URLs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies in the
package.jsonfile to their latest minor or patch versions. The updates affect both runtime and development dependencies, ensuring improved compatibility, new features, and bug fixes.Dependency updates:
Production dependencies:
@deskpro/app-sdkfrom^6.0.6to^6.0.8and@deskpro/deskpro-uifrom^8.3.1to^8.4.0for the latest features and fixes.@sentry/reactfrom^9.38.0to^9.47.1and@sentry/vite-pluginfrom^3.5.0to^3.6.1for improved error tracking.@tanstack/react-query,react-hook-form,react-router-dom, andstyled-componentsto their latest minor/patch versions for stability and new features.Development dependencies:
@swc/core,@swc/helpers, and@types/reactto newer versions for better build and type support.jest-environment-jsdomfrom^30.0.5to^30.2.0,typescriptfrom^5.8.3to^5.9.3, andvitefrom^6.3.6to^6.4.1for improved testing, type checking, and build tooling.Summary by Sourcery
Update application and tooling dependencies to newer minor and patch versions for improved stability and compatibility.
New Features:
Enhancements: