[feature] SC-166737/improve app proxy security by restricting where token replacements can go #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken replacements can go
HappyPaul55
requested review from
Copilot
and removed request for
AshleyDawson
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security for the Trello app by adding settings injection configuration to restrict where API key replacements can occur, while also improving code formatting consistency throughout the manifest file.
- Added
settingsInjectionconfiguration to automatically inject the API key into Trello API requests - Reformatted the entire manifest.json with consistent 2-space indentation for improved readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 9652372 deployed to: https://trello-pr-81.ci.next.deskprodemo.com URLs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes some configuration improvements to the
manifest.jsonfile, primarily focusing on formatting consistency and enhancing API request security by introducing settings injection for whitelisted URLs.Configuration and formatting updates:
callback_urloptions for improved readability and consistency in the JSON structure.API whitelist and security enhancements:
settingsInjectionsection to the Trello API whitelist entry, enabling automatic injection of theapi_keyinto the query string under the keykey, which helps secure API requests and simplifies configuration.