-
Notifications
You must be signed in to change notification settings - Fork 0
[feature] SC-166737/improve app proxy security by restricting where token replacements can go #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…oken replacements can go
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSecure injection of Zoom OAuth credentials into request headers via manifest configuration and removal of unused placeholder constants to streamline the codebase. Class diagram for removed placeholder constants in constants.tsclassDiagram
class Constants {
+ACCESS_TOKEN
+REFRESH_TOKEN_PATH
+REFRESH_TOKEN
+REST_URL
}
%% Removed: placeholders { client_id, client_secret }
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Build for commit 8704730 deployed to: https://zoom-pr-91.ci.next.deskprodemo.com URLs: |
…oken replacements can go
This pull request introduces improvements to how sensitive Zoom OAuth credentials are handled and simplifies the codebase by removing unused constants. The main focus is on securely injecting
client_idandclient_secretinto request headers for OAuth calls, and cleaning up unused placeholder variables.Zoom OAuth credential handling:
manifest.jsonto injectclient_idandclient_secretinto theAuthorizationheaders for POST requests, improving security and flexibility.Codebase cleanup:
placeholdersforclient_idandclient_secretfromsrc/constants.ts, reducing clutter and potential confusion.Summary by Sourcery
Securely inject Zoom OAuth credentials into request headers for POST calls and clean up unused placeholder constants
New Features:
Chores: