Skip to content

Conversation

@HappyPaul55
Copy link
Contributor

@HappyPaul55 HappyPaul55 commented Nov 14, 2025

This pull request introduces improvements to how sensitive Zoom OAuth credentials are handled and simplifies the codebase by removing unused constants. The main focus is on securely injecting client_id and client_secret into request headers for OAuth calls, and cleaning up unused placeholder variables.

Zoom OAuth credential handling:

  • Updated the Zoom OAuth endpoint configuration in manifest.json to inject client_id and client_secret into the Authorization headers for POST requests, improving security and flexibility.

Codebase cleanup:

  • Removed unused placeholders for client_id and client_secret from src/constants.ts, reducing clutter and potential confusion.

Summary by Sourcery

Securely inject Zoom OAuth credentials into request headers for POST calls and clean up unused placeholder constants

New Features:

  • Securely inject Zoom OAuth client_id and client_secret into Authorization headers for POST requests

Chores:

  • Remove unused client_id and client_secret placeholder constants from src/constants.ts

@HappyPaul55 HappyPaul55 requested a review from a team as a code owner November 14, 2025 11:40
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Secure injection of Zoom OAuth credentials into request headers via manifest configuration and removal of unused placeholder constants to streamline the codebase.

Class diagram for removed placeholder constants in constants.ts

classDiagram
  class Constants {
    +ACCESS_TOKEN
    +REFRESH_TOKEN_PATH
    +REFRESH_TOKEN
    +REST_URL
  }
  %% Removed: placeholders { client_id, client_secret }
Loading

File-Level Changes

Change Details Files
Configured secure header injection for Zoom OAuth credentials
  • Added settingsInjection block for client_id and client_secret
  • Specified Authorization headers for POST requests to Zoom OAuth endpoints
manifest.json
Removed unused placeholder constants
  • Deleted placeholders object for client_id and client_secret
  • Cleaned up constants.ts by removing dead code
src/constants.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants