Skip to content

Conversation

@FlaminSarge
Copy link
Contributor

@FlaminSarge FlaminSarge commented Nov 17, 2025

Hovering (or long-pressing on mobile) will flip the icon to whatever isn't being displayed (ornament if setting is off, base icon if setting is on).
Setting uses 'all'/'none' instead of boolean so that if in the future we want to expand the setting to only weapons/armor/exotics/etc. we can use the same setting.
This also adds a slight transition for the shiny background animation so it's not as abrupt when it is hovered.
Reduced motion setting is honored and does not include the 0.2s transition, just instantly changing the icon instead.

base_feature.mov
reduced_motion.mov
shiny_background.mov

Changelog: Add setting to toggle display of ornaments and view ornaments when hovering over items

@FlaminSarge
Copy link
Contributor Author

Reduced motion setting is honored and does not include the 0.2s transition, just instantly changing the icon instead.

Debating whether this shouldn't even be included and should just not swap icons at all when reduced-motion.

@FlaminSarge
Copy link
Contributor Author

FlaminSarge commented Nov 17, 2025

Also this does reduce the visual intensity of the masterwork glow for ornamented exotics since it draws behind the icon if it has an ornament, I believe (due to the whole background/foreground thing being skipped in the !animatedBackground && !altIcon block).

Also tested on mobile, does work with the long-press, since that triggers hover and we don't have anything hooked up to long-press on DIM.

@bhollis
Copy link
Contributor

bhollis commented Nov 22, 2025

Also tested on mobile, does work with the long-press, since that triggers hover and we don't have anything hooked up to long-press on DIM.

In sheets like the pull item sheet, we do use long press to activate the item popup. I'm not worried about it.

@FlaminSarge
Copy link
Contributor Author

FlaminSarge commented Dec 24, 2025

(Planning to rebase and squash this once it's ready)

@FlaminSarge
Copy link
Contributor Author

FlaminSarge commented Dec 28, 2025

Rebased and condensed down to 3 independent commits, should be ready to go. No changes from original branch other than en.json update.

…aments when hovering over items

Includes:
icon fades into alternate icon with 0.2s transition
icon fade is instant for reduced-motion preference
masterworkGlow now shows up on top of foreground/altIcon
content-visibility is used to hide the inactive icon
example ornamented item is previewed on settings page
@FlaminSarge FlaminSarge requested a review from bhollis December 28, 2025 19:39
@bhollis bhollis merged commit 6d777de into master Dec 30, 2025
4 checks passed
@bhollis bhollis deleted the ornaments branch December 30, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants