-
-
Notifications
You must be signed in to change notification settings - Fork 650
Add setting to toggle display of ornaments, with hover to preview opposite state #11596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Debating whether this shouldn't even be included and should just not swap icons at all when reduced-motion. |
18e47d0 to
c6f2b98
Compare
|
Also tested on mobile, does work with the long-press, since that triggers hover and we don't have anything hooked up to long-press on DIM. |
c6f2b98 to
165bfdd
Compare
In sheets like the pull item sheet, we do use long press to activate the item popup. I'm not worried about it. |
2331f89 to
76ec839
Compare
|
|
b4efdfb to
db105b8
Compare
|
Rebased and condensed down to 3 independent commits, should be ready to go. No changes from original branch other than en.json update. |
db105b8 to
a2fa22b
Compare
…aments when hovering over items Includes: icon fades into alternate icon with 0.2s transition icon fade is instant for reduced-motion preference masterworkGlow now shows up on top of foreground/altIcon content-visibility is used to hide the inactive icon example ornamented item is previewed on settings page
a2fa22b to
077a523
Compare
…s transition to match opacity
Hovering (or long-pressing on mobile) will flip the icon to whatever isn't being displayed (ornament if setting is off, base icon if setting is on).
Setting uses 'all'/'none' instead of boolean so that if in the future we want to expand the setting to only weapons/armor/exotics/etc. we can use the same setting.
This also adds a slight transition for the shiny background animation so it's not as abrupt when it is hovered.
Reduced motion setting is honored and does not include the 0.2s transition, just instantly changing the icon instead.
base_feature.mov
reduced_motion.mov
shiny_background.mov
Changelog: Add setting to toggle display of ornaments and view ornaments when hovering over items