Skip to content

Conversation

@lyuha
Copy link

@lyuha lyuha commented Nov 26, 2025

In weapon compare panel, add a quick filter button matching same elemental type and same weapon frame.

image

@bhollis
Copy link
Contributor

bhollis commented Nov 26, 2025

That's a lot of buttons! We should probably implement an overflow thing that scrolls them or collapses the overflow into a menu.

@bhollis
Copy link
Contributor

bhollis commented Nov 26, 2025

Or we could have a bunch of checkboxes to filter... or a search language...

@lyuha
Copy link
Author

lyuha commented Nov 26, 2025

I think that the checkbox design conflict with the compare feature.
How do these checkboxes (☑ kinetic ☐ frame ☑ kineticslot ☐ legendary) convert to search query? is:kinetic and is:kineticslot or is:kinetic or is:kineticslot?

How about change frame name to frame icon for making buttons shorter?

@chainrez
Copy link
Contributor

How do these checkboxes (☑ kinetic ☐ frame ☑ kineticslot ☐ legendary) convert to search query? is:kinetic and is:kineticslot or is:kinetic or is:kineticslot?

The former.

That said, we cannot add every single permutation there will be 20 buttons and it will be unusable.
On mobile, the existing number of buttons already takes up half the screen, not exaggerating. I need to draw a line here and say no more weapon buttons right now, until we have a new way of displaying/expressing these options.

@lyuha
Copy link
Author

lyuha commented Nov 28, 2025

That said, we cannot add every single permutation there will be 20 buttons and it will be unusable.

I agree too. If buttons are 10, 20 or more, it is unusable. But I added this single button to add a missing option following the current rule(quickly compare damage type/weapon frame/slot/others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants