Skip to content

Only attempt updates that pass validation #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhollis merged 1 commit into from
Dec 18, 2024
Merged

Only attempt updates that pass validation #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions api/routes/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ export const updateHandler = asyncHandler(async (req, res) => {
migrationState.state !== desiredMigrationState;

const results: ProfileUpdateResult[] = validateUpdates(req, updates, platformMembershipId, appId);
// Only attempt updates that pass validation
const updatesToApply = updates.filter((_, index) => results[index].status === 'Success');

const importToStately = async () => {
// Export from Postgres
Expand Down Expand Up @@ -161,18 +163,24 @@ export const updateHandler = asyncHandler(async (req, res) => {
// For now let's leave the old data in Postgres as a backup
await doMigration(bungieMembershipId, importToStately);
await statelyUpdate(
updates,
updatesToApply,
bungieMembershipId,
platformMembershipId ?? profileIds[0],
destinyVersion,
);
} else {
await pgUpdate(updates, bungieMembershipId, platformMembershipId, destinyVersion, appId);
await pgUpdate(
updatesToApply,
bungieMembershipId,
platformMembershipId,
destinyVersion,
appId,
);
}
break;
case MigrationState.Stately:
await statelyUpdate(
updates,
updatesToApply,
bungieMembershipId,
platformMembershipId ?? profileIds[0],
destinyVersion,
Expand Down
Loading