Skip to content

fix(windows): error on full index - use cmd.exe-compatible syntax (Fixes #324) #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hippus wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

fix(windows): error on full index - use cmd.exe-compatible syntax (Fixes #324) #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/pipeline/pass_githistory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,16 @@ static int parse_git_log(const char *repo_path, commit_t **out, int *out_count)
}

char cmd[CBM_SZ_1K];
#ifdef _WIN32
/* cmd.exe does not recognize single quotes; '/dev/null' is a POSIX path. */
const char *null_dev = "NUL";
#else
const char *null_dev = "/dev/null";
#endif
snprintf(cmd, sizeof(cmd),
"cd '%s' && git log --name-only --pretty=format:COMMIT:%%H "
"--since='1 year ago' --max-count=10000 2>/dev/null",
repo_path);
"git -C \"%s\" log --name-only --pretty=format:COMMIT:%%H "
"--since=\"1 year ago\" --max-count=10000 2>%s",
repo_path, null_dev);

FILE *fp = cbm_popen(cmd, "r");
if (!fp) {
Expand Down