Fix code scanning alert #78: Log Injection #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![senior-dev-bot[bot]](https://avatars.githubusercontent.com/in/282840?s=60&v=4){kind=small}
Comment on lines
392
to
399
| """ | ||
| logging.info('Deleting Employee') | ||
| logging.debug(f"Deleting for EmployeeCode: {EmployeeCode}") | ||
| sanitized_employee_code = re.sub(r'\D', '', str(EmployeeCode)) | ||
| logging.debug(f"Deleting for EmployeeCode: {sanitized_employee_code}") | ||
| client2.find_one_and_delete(collection2, {'EmployeeCode': EmployeeCode}) | ||
|
|
||
| return {'Message': 'Successfully Deleted'} |
There was a problem hiding this comment.
CODE REVIEW
Good job on sanitizing the EmployeeCode before logging! However, ensure that the original variable remains unchanged for further operations. Alternatively, consider logging the sanitized value conditionally based on the logging level to avoid unnecessary processing.
sanitized_employee_code = re.sub(r'\D', '', str(EmployeeCode))
if logging.getLogger().isEnabledFor(logging.DEBUG):
logging.debug(f"Deleting for EmployeeCode: {sanitized_employee_code}")
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 task
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Devasy23/FaceRec/security/code-scanning/78
Suggested fixes powered by Copilot Autofix. Review carefully before merging.