Skip to content

Conversation

@tleguern
Copy link
Contributor

@tleguern tleguern commented Apr 9, 2019

This is taken straight from
devops-coop/ansible-haproxy#104.

Credits to Reza Jelveh AKA @fishman.

@tleguern tleguern requested a review from a user April 9, 2019 15:20
@tleguern
Copy link
Contributor Author

tleguern commented Apr 9, 2019

Tested against Debian jessie.

@tleguern
Copy link
Contributor Author

tleguern commented Apr 9, 2019

Would close issue #15.

kurotoshiro
kurotoshiro previously approved these changes Apr 10, 2019
Copy link
Collaborator

@kurotoshiro kurotoshiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with #21, another step for a sane default config

👍 Ok for me

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those comments must be to apply to all the copy declaration.

@kurotoshiro kurotoshiro added this to the v1.3.0 milestone Apr 11, 2019
This is taken straight from
devops-coop/ansible-haproxy#104.

Credits to Reza Jelveh AKA @fishman.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ghost ghost merged commit f5e5d43 into Deveryware:master Apr 15, 2019
@tleguern tleguern deleted the ship-error-files branch April 15, 2019 13:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants