Dev 276 google analytics rebase #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… button, submit button and pressing enter for searching and send it to GoogleAnalytics. * Create a separate GoogleAnalyticsService describing the methods to use for recording events to Google Analytics.
aashil
force-pushed
the
dev-276-google-analytics-rebase
branch
from
d855e53 to
9357483
Compare
…mock the actual implementation of the methods which record the events. * We do this to not record the events for tests.
|
I don't see any tests for this. I'd like to see something that tests that the GA events are called at the right times. |
…ecific times. * Use spyOn and expect the GA method to have been called with specific parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't discussed about the tests and the ticket didn't mentioned anything about the tests. I would not have known.