Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the development and production setup, CI/CD workflows, and database migration management for the project. The most significant changes include a Dockerfile refactor for multi-stage builds, the addition of production and development environment templates for object storage, improved CI coverage for the UI, and the removal of checked-in Alembic migration scripts.
Build and deployment improvements:
api/app/Dockerfileto use a multi-stage build, separating dependency installation and runtime, switching to a non-root user, and adding a healthcheck for better production security and maintainability..env.prod.exampleas a template for production environment variables, including sections for Postgres, Redis, API, OAuth, email, object storage, and observability.api/app/.env.exampleto support user uploads in development.Continuous integration improvements:
ui-ciGitHub Actions workflow to ensure UI tests are run during CI.api-ciworkflow to fail on test errors (other than "no tests found") by removing the workaround that ignored exit code 5 from pytest.Database migration management:
api/app/alembic/versions/24b35055e774_init_initial_migration.pyandapi/app/alembic/versions/7d6ba2fe0af9_feat_add_workspace_invitations_table.py), likely in preparation for regeneration or to avoid version conflicts. [1] [2]