vcpkg - prevent crash when duplicate triplets exist in triplets directories#4538
Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
March 31, 2026 13:28
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents a crash in the vcpkg settings UI caused by duplicate triplet names when both triplets/ and triplets/community/ contain the same triplet, by de-duplicating triplet names during enumeration.
Changes:
- Skip adding a triplet name if it has already been added to the returned list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Mar 31, 2026
Marc-André Moreau (mamoreau-devolutions)
merged commit 4b82636
into
main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetSystemTriplets() concatenates triplets from both triplets/ and triplets/community/, which can produce duplicate names when the same triplet exists in both directories.
ComboboxCard.AddItem uses the triplet name as a dictionary key, causing an ArgumentException crash when navigating to the vcpkg settings page.
Fixed by skipping already-seen triplet names when building the list