Address PR #30 review comments: add validations and shared token caching#31
Merged
Dion Gionet Mallet (dion-gionet) merged 4 commits intodevops/lookuppluginfrom Jan 15, 2026
Merged
Conversation
Copilot started work on behalf of
Dion Gionet Mallet (dion-gionet)
January 15, 2026 13:19
View session
Co-authored-by: dion-gionet <29441318+dion-gionet@users.noreply.github.com>
Co-authored-by: dion-gionet <29441318+dion-gionet@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add lookup plugins for inline credential retrieval
Address PR #30 review comments: add validations and shared token caching
Jan 15, 2026
Danny Bédard (DannyBedard)
approved these changes
Jan 15, 2026
Co-authored-by: dion-gionet <29441318+dion-gionet@users.noreply.github.com>
c66006f to
ae2ad92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #30 to improve error handling, reduce redundant authentication, and enhance code quality.
Changes
Unique entry validation: Added
validate_unique_entrycalls inget_vault_entry_from_pathandget_vault_entry_from_typeto prevent ambiguous matches when multiple entries share the same path/typeModule-level token caching: Converted instance-based token cache to module-level shared cache, allowing
secretandsecret_fulllookup plugins to reuse authentication tokens across instances in the same playbook runEntry validation: Added checks for missing
entry_idand empty credential objects inget_credential, with improved error messages including server URL for debuggingDocumentation: Split long field lists in
secret.pyacross multiple lines, removed duplicate field documentation from notes sectionToken Caching Example
Before (instance-level):
After (module-level):
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.