Skip to content

[Secret Sharing] Migrate to blahaj to fix a bias #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdugre merged 1 commit into from
Nov 20, 2024
Merged

[Secret Sharing] Migrate to blahaj to fix a bias #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 30 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ hmac = "0.12"
num_enum = "0.7"
pbkdf2 = { version = "0.12", default-features = false }
scrypt = { version = "0.11", default-features = false }
sharks = "0.5"
blahaj = { version = "0.6", default-features = false }
sha2 = "0.10"
strum = { version = "0.26", features = ["derive"] }
subtle = "2"
Expand Down Expand Up @@ -72,6 +72,6 @@ wasm-bindgen-test = "0.3"

[features]
default = []
fuzz = ["arbitrary", "sharks/fuzzing"]
fuzz = ["arbitrary", "blahaj/fuzzing"]
wbindgen = ["wasm-bindgen", "serde-wasm-bindgen", "js-sys"]

6 changes: 4 additions & 2 deletions src/secret_sharing/secret_sharing_v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ use super::Result;

use std::convert::TryFrom;

use sharks::{Share, Sharks};
use rand::rngs::OsRng;

use blahaj::{Share, Sharks};
use zeroize::Zeroizing;

#[cfg(feature = "fuzz")]
Expand Down Expand Up @@ -66,7 +68,7 @@ impl ShareV1 {

let secret = Zeroizing::new(crate::utils::generate_key(length));
let sharks = Sharks(threshold);
let dealer = sharks.dealer(&secret);
let dealer = sharks.dealer_rng(&secret, &mut OsRng);

Ok(dealer.take(n_shares as usize).map(move |s| ShareV1 {
threshold,
Expand Down
Loading