Skip to content

Conversation

@IgorTodorovskiIBM
Copy link
Collaborator

Since the new zopen symlinks all binaries, libraries, and man pages under a common bin, lib, share location, we no longer need to set the PATH, LIBPATH and MANPATH environment variables. However, if someone downloads the tool manually, then we should still retain that logic. So the idea is that we would decouple the required environment variables away from the .env into a .appenv, which zopen-config would source. This would greatly speed up the .zopen-config processing.

If there's any environment variables that are used within the application process, they should use zopen_append_to_zoslib_env (as in the case of Git):

zopen_append_to_zoslib_env() {
cat <<EOF
GIT_TEMPLATE_DIR|set|PROJECT_ROOT/share/git-core/templates
GIT_EXEC_PATH|set|PROJECT_ROOT/libexec/git-core
GIT_SSL_CAINFO|set|PROJECT_ROOT/cacert.pem
EOF
}

But variables that are needed by other tools or processes should go into zopen_append_to_env (we might need to change the name) as in the case of autoconf:

zopen_append_to_env()
{
cat <<EOF
export autom4te_perllibdir=\${PWD}/share/autoconf
export AC_MACRODIR=\${PWD}/share/autoconf


#To set M4 variable path
if [ -z "${M4_HOME}"  ]; then
    echo "Ensure M4_HOME is set and re-source the .env"
else
    export M4="\$M4_HOME/bin/m4"
fi
EOF
}

This would require a new build of all tools that have zopen_append_to_env logic.

DevonianTeuchter and others added 30 commits May 26, 2023 20:40
incorporating generic trap handler to
try and restore terminal behaviour on abend
or exit
Provide basic runtime mutexing
Reverse "find" command
Wrapper for "find" to ensure "/bin/find" rather
than findutils (when/if installed)
cleanup code to run.
Add logic to print functions to restrict
output when "-x" debug active.
system requiring initialisation logic,
addition, removal and certification
management.
allow selection of available package
versions
obsolete resources
instructions and details
ensure resources cleaned up and
long symlinks handled.
Bit of code cleanup around the logic also
IgorTodorovskiIBM and others added 24 commits August 10, 2023 22:01
Add --all option to zopen install --help
Add a disk space check to zopen install
Add option to append sourcing of .zopen-config to .profile + quick processing of .zopen-config
Fix install for tools that are substrings of other tools
…nfig to allow for development versions of zopen
Allow user to select STABLE or DEV release
… if there have been any updates. Also fix an issue with fifo's not tagged
Download JSON cache only if there are updates
Update documentation to reflect new zopen commands
Copy link
Owner

@DevonianTeuchter DevonianTeuchter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and should improve init times for zopen-config

@IgorTodorovskiIBM
Copy link
Collaborator Author

I'll hold off merging this until after the beta since we'll need to trigger builds for most tools to get this to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants