forked from zopencommunity/meta
-
Notifications
You must be signed in to change notification settings - Fork 0
Optimize .env and .zopen-config processing #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
IgorTodorovskiIBM
wants to merge
74
commits into
DevonianTeuchter:main
Choose a base branch
from
IgorTodorovskiIBM:change_env_processing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Optimize .env and .zopen-config processing #52
IgorTodorovskiIBM
wants to merge
74
commits into
DevonianTeuchter:main
from
IgorTodorovskiIBM:change_env_processing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incorporating generic trap handler to try and restore terminal behaviour on abend or exit
Provide basic runtime mutexing Reverse "find" command Wrapper for "find" to ensure "/bin/find" rather than findutils (when/if installed)
cleanup code to run. Add logic to print functions to restrict output when "-x" debug active.
capability
system requiring initialisation logic, addition, removal and certification management.
allow selection of available package versions
obsolete resources
instructions and details
-x debug output
reworked http handling
UX changes
ensure resources cleaned up and long symlinks handled. Bit of code cleanup around the logic also
Add --all option to zopen install --help
Add a disk space check to zopen install
Add option to append sourcing of .zopen-config to .profile + quick processing of .zopen-config
Fix install for tools that are substrings of other tools
…nfig to allow for development versions of zopen
Use relative zopen-download
Allow user to select STABLE or DEV release
… if there have been any updates. Also fix an issue with fifo's not tagged
Download JSON cache only if there are updates
Update documentation to reflect new zopen commands
fix for print elapsed time exit issue
DevonianTeuchter
approved these changes
Aug 18, 2023
Owner
DevonianTeuchter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and should improve init times for zopen-config
HarithaIBM
approved these changes
Aug 22, 2023
Collaborator
Author
|
I'll hold off merging this until after the beta since we'll need to trigger builds for most tools to get this to work. |
d68299e to
d19e070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new zopen symlinks all binaries, libraries, and man pages under a common bin, lib, share location, we no longer need to set the PATH, LIBPATH and MANPATH environment variables. However, if someone downloads the tool manually, then we should still retain that logic. So the idea is that we would decouple the required environment variables away from the .env into a .appenv, which zopen-config would source. This would greatly speed up the .zopen-config processing.
If there's any environment variables that are used within the application process, they should use
zopen_append_to_zoslib_env(as in the case of Git):But variables that are needed by other tools or processes should go into
zopen_append_to_env(we might need to change the name) as in the case of autoconf:This would require a new build of all tools that have zopen_append_to_env logic.