Skip to content

Feat/add savings goal milestone notification#502

Merged
Devsol-01 merged 3 commits intoDevsol-01:mainfrom
MerlinTheWhiz:feat/add-savings-goal-milestone-notification
Mar 29, 2026
Merged

Feat/add savings goal milestone notification#502
Devsol-01 merged 3 commits intoDevsol-01:mainfrom
MerlinTheWhiz:feat/add-savings-goal-milestone-notification

Conversation

@MerlinTheWhiz
Copy link
Copy Markdown
Contributor

Closes #466

Changes I made:

  • Backend (core changes)

    • savings-goal.entity.ts — Added milestonesSent (JSONB) to track sent milestone percentages.
    • 1774445030-AddGoalMilestonesAndPreferences.ts — Migration adding milestonesSent, milestoneNotifications, goal_milestone_events table, and safe enum updates.
    • notification.entity.ts — Added GOAL_MILESTONE, GOAL_COMPLETED types.
    • notification-preference.entity.ts — Added milestoneNotifications (default true).
    • update-notification-preference.dto.ts — Added milestoneNotifications to PATCH DTO.
    • notifications.service.ts — Added goal.milestone handler for in-app + email notifications (respects prefs).
    • mail.service.ts — Added sendGoalMilestoneEmail(...) with template.
    • milestone-scheduler.service.ts — Daily cron to compute progress, mark milestones, emit events, and log analytics.
    • notifications.module.ts — Registered scheduler and imported SavingsModule.
    • goal-milestone.hbs — Email template for milestone notifications.
  • Frontend

    • page.tsx — Replaced placeholder with settings UI to fetch/update notification preferences (including milestoneNotifications).

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nestera Ready Ready Preview, Comment Mar 29, 2026 11:28am

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 29, 2026

@MerlinTheWhiz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Devsol-01 Devsol-01 merged commit 5c8584f into Devsol-01:main Mar 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Savings Goal Milestone Notifications

2 participants