PR-117 Review and Updates#119
Merged
ar-siddiqui merged 1 commit intofeature/add-tagsfrom Apr 15, 2026
Merged
Conversation
Merged
Akopti8
approved these changes
Apr 13, 2026
Collaborator
Akopti8
left a comment
There was a problem hiding this comment.
All looks good to me, thanks for seperating out and detailing all the updates!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Akopti8 Good work with adding tags feature. I reviewed your PR and made some changes:
Changed tag serach to be only prefix based not contain based, because we don't want to match to
dev1when we are looking forv1Fix some places where tags were not returned or were returned empty
Added tags in Pagination links
Updated one of the Postman test to now test for only prefix matching
Allowed collon in tags
I also added following additional feature: