Conversation
…ken launch implementation. PortfolioSub: renamed autoFill as autoGas PortfolioSub: Removed floor from the fee calculations and added minmum automic 1 uniit fee, In other to fully allow much smaller taker orders using minTradeAmounts. if $1 trades are allowed, people would have paid no commissions without this change. TradePairs: repurposed tradePair.auctionPrice to hold omnivault address using setAuctionVaultAdress & getAuctionVaultAdress TradePairs: added requires to MinPostAmount & minTradeAmount. MinPostAmount is always >= minTradeAmount. TradePairs: added a new unsolicited cancel use case where partially filled resting orders are canceled if their remaining is less than minTradeAmount /10 for good ob hygene. TradePairs: Removed redundant "return takerOrder" from matchOrder TradePairs: Removed redundant "return takerOrder" from addExecution TradePairs: Removed the redundant "return price" from addOrderChecks TradePairs: Added decrement to Count STP-driven cancellations toward the gas iteration budget. ExchangeSub : addToken bug fix ( _srcChainSymbol, _subnetSymbol were in opposite locations. ExchangeSub : Documented the new Auction Workflow UtilsLibrary: uint256ToAddress , addressToUint256 & getFee functions package upgrades
ngurmen
approved these changes
Mar 19, 2026
… orderMap TradePairs: Use of the new Execution struct to save gas & increase readibility PortfolioSub: Use of the new Execution struct to save gas & increase readibility and combine getFeeRates with calculateFeeAmounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsolete auction logic removed. Added simple controls for a future token launch implementation.
PortfolioSub: renamed autoFill as autoGas
PortfolioSub: Removed floor from the fee calculations and added minmum automic 1 uniit fee, In other to fully allow much smaller taker orders using minTradeAmounts. if $1 trades are allowed, people would have paid no commissions without this change.
PortfolioSub: Use of the new Execution struct to save gas & increase readability and combine getFeeRates with calculateFeeAmounts functions
TradePairs: repurposed tradePair.auctionPrice to hold omnivault address using setAuctionVaultAdress & getAuctionVaultAdress
TradePairs: added requires to MinPostAmount & minTradeAmount. MinPostAmount is always >= minTradeAmount.
TradePairs: added a new unsolicited cancel use case where partially filled resting orders are canceled if their remaining is less than minTradeAmount /10 for good ob hygene.
TradePairs: Removed redundant "return takerOrder" from matchOrder
TradePairs: Removed redundant "return takerOrder" from addExecution
TradePairs: Removed the redundant "return price" from addOrderChecks
TradePairs: Added decrement to maxNbrOfFills to include STP-driven cancellations toward the gas iteration budget.
TradePairs: Gas Optimization by minmizing lookups from tradePairMap & orderMap
TradePairs: Use of the new Execution struct for Gas Optimization & increase readability
ExchangeSub : bug fix of the obsolete function addToken ( _srcChainSymbol, _subnetSymbol were in opposite locations) we may be used again.
ExchangeSub : Documented the new Auction Workflow
UtilsLibrary: uint256ToAddress , addressToUint256 & getFee functions
package upgrades