fix: Pin the system test containers #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
commented
Aug 1, 2025
Comment on lines
+64
to
+76
| "customManagers": [ | ||
| { | ||
| "customType": "regex", | ||
| "fileMatch": [ | ||
| "^\\.github/workflows/[^/]+\\.ya?ml$" | ||
| ], | ||
| "matchStringsStrategy": "combination", | ||
| "matchStrings": [ | ||
| "uses: actions/checkout@v*\\s", | ||
| "repository: (?<depName>.*?)\\s", | ||
| "ref: (?<currentValue>.*?)\\s" | ||
| ], | ||
| "datasourceTemplate": "github-tags" |
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I might be worth looking for a fileMatch of Dockerfile to ignore creating this type of PR
Contributor
Author
There was a problem hiding this comment.
I believe our Dockerfiles will stop having ARG of python version once we're using uv, which means we can then pin to the version of python we actually use for our build and the spurious PRs will be much reduced (along with uv better control of dependencies)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 41 41
Lines 2544 2544
=======================================
Hits 2404 2404
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ZohebShaikh
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example-services compose-file that we for our system tests is adjusting the ports that it uses. As we are tracking main of that repository we need to pin this dependency, allowing the ports to be adjusted for the next release.
With Renovate we should be able to keep the dependency pinned and use the latest releases, which will require an adjustment to the ports when the release is made.