Skip to content

Conversation

@DominicOram
Copy link
Contributor

Fixes #1359

Instructions to reviewer on how to test:

  1. Confirm test passes

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@DominicOram DominicOram requested a review from a team as a code owner October 15, 2025 14:00
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (a67e067) to head (c0d5c48).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files         133      133           
  Lines        7960     7965    +5     
=======================================
+ Hits         7185     7190    +5     
  Misses        775      775           
Components Coverage Δ
i24 SSX 75.27% <ø> (ø)
hyperion 97.89% <100.00%> (+<0.01%) ⬆️
other 97.90% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 self-assigned this Oct 23, 2025


def _perform_robot_unload(context: BlueskyContext, visit: str) -> MsgGenerator:
def _clean_up_udc(context: BlueskyContext, visit: str) -> MsgGenerator:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a note on #1389 that it will need updating when this gets merged as the hyperion-blueapi does not depend on the baton handler and therefore can't see this plan

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@DominicOram DominicOram merged commit 888ccd0 into main Oct 23, 2025
24 checks passed
@DominicOram DominicOram deleted the 1359_close_detector_shutter_on_baton_handover branch October 23, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hyperion: Close detector cover when handing baton back to GDA

3 participants