Skip to content

Conversation

@adedamola-sode
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.73%. Comparing base (ae1ac48) to head (dd44da5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #158       +/-   ##
===========================================
+ Coverage   56.39%   81.73%   +25.34%     
===========================================
  Files           7        7               
  Lines         571      564        -7     
===========================================
+ Hits          322      461      +139     
+ Misses        249      103      -146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@OCopping OCopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few cases where only the main logic path is tested. Can tests be also added for other bits of logic please?
e.g. in _get_screen_dimensions there are no tests to test the AttributeError catches:

Image

@OCopping
Copy link
Collaborator

I will note, regarding Mocking, things can get complicated if the mocked functions are very complex. Let me know if you need any help with it 😃

Copy link
Collaborator

@OCopping OCopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Can you squash some commits though to tidy the branch (e.g. squash the "modified tests" and "added tests" ones together if possible)?

Modified tests
@adedamola-sode adedamola-sode merged commit 4df7e23 into main Nov 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants