Fix devcontainer venv 2 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 52.00% 52.00%
=======================================
Files 3 3
Lines 100 100
=======================================
Hits 52 52
Misses 48 48 ☔ View full report in Codecov by Sentry. |
OCopping
force-pushed
the
fix-devcontainer-venv-2
branch
2 times, most recently
from
a28bb16 to
5583343
Compare
Converted to hatch from tox
OCopping
force-pushed
the
fix-devcontainer-venv-2
branch
from
5583343 to
ce2bc87
Compare
Removed devcontainer venv create command as not needed and broke things
OCopping
force-pushed
the
fix-devcontainer-venv-2
branch
from
d4780fa to
9dedca5
Compare
adedamola-sode
approved these changes
Feb 28, 2025
Collaborator
adedamola-sode
left a comment
adedamola-sode
left a comment
There was a problem hiding this comment.
Hatch for tools work, uv for package dependencies works.
adedamola-sode
pushed a commit
that referenced
this pull request
Feb 28, 2025
* Fix file copying and pdm install in Dockerfile * Remove Sphinx version pinning as we don't care about Python 3.9 * Update pdm.lock * Fix post-install.sh venv creation * Convert to use uv from pdm Converted to hatch from tox * Add version raw options to remove dev and timestamp tags (for local builds) * Fixes to Dockerfile Removed devcontainer venv create command as not needed and broke things
adedamola-sode
pushed a commit
that referenced
this pull request
Feb 28, 2025
* Fix file copying and pdm install in Dockerfile * Remove Sphinx version pinning as we don't care about Python 3.9 * Update pdm.lock * Fix post-install.sh venv creation * Convert to use uv from pdm Converted to hatch from tox * Add version raw options to remove dev and timestamp tags (for local builds) * Fixes to Dockerfile Removed devcontainer venv create command as not needed and broke things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes to bugs found when building the devcontainer