Skip to content

Conversation

@adedamola-sode
Copy link
Collaborator

Added submodules.
Added guibuilder tests
Cherry-picked datatype and phoebus-guibuilder functional separation
Rebased on main

adedamola-sode and others added 21 commits February 7, 2025 14:18
* Fix versioning and tox env

* Fix create_gui.yaml path

* More pyproject.toml fixes (versioning, tox); Added missing cdocs/conf.py

* Fixes to tox envs for CI
Bumps the actions group with 2 updates: [softprops/action-gh-release](https://github.com/softprops/action-gh-release) and [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `softprops/action-gh-release` from 2.0.9 to 2.2.1
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@e7a8f85...c95fe14)

Updates `codecov/codecov-action` from 4 to 5
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4...v5)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Rebasing phoebus class redesign with changes made to testing and
dependencies.
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 90.29126% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.45%. Comparing base (10409c0) to head (07be562).

Files with missing lines Patch % Lines
src/phoebus_guibuilder/guibuilder.py 87.69% 8 Missing ⚠️
src/phoebus_guibuilder/__main__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #23       +/-   ##
===========================================
+ Coverage   52.00%   91.45%   +39.45%     
===========================================
  Files           3        4        +1     
  Lines         100      117       +17     
===========================================
+ Hits           52      107       +55     
+ Misses         48       10       -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adedamola-sode
Copy link
Collaborator Author

Closing because it's an attempt to merge main into submodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants