Skip to content

Conversation

@adedamola-sode
Copy link
Collaborator

Added examples, services
Added guibuilder and datatypes
added tests

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.96%. Comparing base (b900f4e) to head (ead0d23).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/phoebus_guibuilder/guibuilder.py 94.23% 3 Missing ⚠️
src/phoebus_guibuilder/__main__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   52.00%   95.96%   +43.96%     
===========================================
  Files           3        5        +2     
  Lines         100      124       +24     
===========================================
+ Hits           52      119       +67     
+ Misses         48        5       -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OCopping
Copy link
Collaborator

@adedamola-sode is this branch ready for merge?

@adedamola-sode
Copy link
Collaborator Author

Yes, does it look like there's anything missing?

@OCopping OCopping self-requested a review April 25, 2025 10:57
Copy link
Collaborator

@OCopping OCopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@adedamola-sode adedamola-sode merged commit e89aff2 into main Apr 25, 2025
15 checks passed
@adedamola-sode adedamola-sode deleted the submodule branch July 21, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants