fixed bug in signIn template with login button #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@misutowolf - That does seem to do the trick. Thanks. |
Author
|
No problem! |
Contributor
|
Good call. |
Contributor
|
Oops, looks like it is out of date. Can you merge master in and update your repo? |
Author
|
Eep. I'm a GitHub noob. How do I go about doing that? Will be glad to. |
Contributor
|
@misutowolf |
|
I've added a PR #240 with fixes both this issue and issue #221 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug that seemingly prevented the signIn button from being shown when using USERNAME_ONLY and accounts-password as a provider.
Hopefully this line being moved is indeed a proper solution!