Skip to content

Translated in Korean #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Translated in Korean #316

wants to merge 8 commits into from

Conversation

AndyH0ng
Copy link

No description provided.

Copy link
Collaborator

@ericlewis ericlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is partial at best but sure.

@AndyH0ng
Copy link
Author

AndyH0ng commented Sep 3, 2020

Oh so am i supposed to merge with legacy?

@TheVaan
Copy link
Collaborator

TheVaan commented Sep 3, 2020

We won't release an other legacy update. Next up is iOS 14 with our iOS 14 app release.

@ericlewis
Copy link
Collaborator

@AndyH0ng this is incomplete so we can't merge at all- please update!

Copy link
Collaborator

@ericlewis ericlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do all

@TheVaan
Copy link
Collaborator

TheVaan commented Sep 24, 2020

You can find all translations in the German and French file.
The English file only contains translations where the key is different to the text we want to show. In the other files you will find more keys to translate. You don't have to understand the translated part of each line because the "real English string" is the key.

@AndyH0ng
Copy link
Author

Oh i get it now. Thanks 👍

@TheVaan
Copy link
Collaborator

TheVaan commented Oct 5, 2020

Really good work! Great! Just a few strings that are still in French in your file and your are 100 percent done! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants