Cabeçalho#17
Open
Kevin-Sarges wants to merge 4 commits intoDiogo-Felipe:masterfrom
Kevin-Sarges:cabecalho
Open
Cabeçalho#17Kevin-Sarges wants to merge 4 commits intoDiogo-Felipe:masterfrom Kevin-Sarges:cabecalho
Kevin-Sarges wants to merge 4 commits intoDiogo-Felipe:masterfrom
Kevin-Sarges:cabecalho
Conversation
Alterando o posicionamento do canvas
Adição das meta tags
Owner
Diogo-Felipe
left a comment
Diogo-Felipe
left a comment
There was a problem hiding this comment.
@Kevin-Sarges, Verifica as mudanças que eu sugeri. Acredito que elas são boas. Mas no mais o código está bem feito
Comment on lines
+18
to
+22
| <header> | ||
| <div id="cabecalho"> | ||
| <h1>Evolutionism Simulator</h1> | ||
| </div> | ||
| </header> |
Owner
There was a problem hiding this comment.
Aqui poderia ser retirada essa
e colocado o h1 diretamente dentro do header. Isso torna o código mais semântico| @@ -1,3 +1,10 @@ | |||
| #cabecalho{ | |||
Owner
There was a problem hiding this comment.
Combinado ao comentário feito no HTML, aqui poderiamos ao invés de usar o "#cabecalho", usar simplesmente "header".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eu adicionei o cabeçalho na pagina e estilizei ele colocando uma fonte diferente e ajustado ele no centro da pagina.