Skip to content

Don't make new windows visible until after AccessKit has initialized #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoburns merged 1 commit into from
Feb 14, 2026
Merged

Don't make new windows visible until after AccessKit has initialized #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/blitz-shell/src/window.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,18 @@ impl<Rend: WindowRenderer> View<Rend> {
event_loop: &dyn ActiveEventLoop,
proxy: &BlitzShellProxy,
) -> Self {
let winit_window: Arc<dyn Window> =
Arc::from(event_loop.create_window(config.attributes).unwrap());
// We create window as invisble and then later make window visible
// after AccessKit has initialised to avoid AccessKit panics
let is_visible = config.attributes.visible;
let attrs = config.attributes.with_visible(false);

let winit_window: Arc<dyn Window> = Arc::from(event_loop.create_window(attrs).unwrap());
#[cfg(feature = "accessibility")]
let accessibility = AccessibilityState::new(&*winit_window, proxy.clone());

if is_visible {
winit_window.set_visible(true);
}

// Create viewport
// TODO: account for the "safe area"
Expand Down Expand Up @@ -133,7 +143,7 @@ impl<Rend: WindowRenderer> View<Rend> {
pointer_pos: Default::default(),
is_visible: winit_window.is_visible().unwrap_or(true),
#[cfg(feature = "accessibility")]
accessibility: AccessibilityState::new(&*winit_window, proxy.clone()),
accessibility,

#[cfg(target_os = "ios")]
ios_request_redraw: std::cell::Cell::new(false),
Expand Down
Loading