-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feat: eager loading of assets #4653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: eager loading of assets #4653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An option to inject stylesheets and scripts at compile time into the head would be great, but I don't think it should be the default. manganis is built to work across libraries and this doesn't seem like a good default for libraries. Adding dioxus-components
should not inject the stylesheet into the head for components I don't use automatically
Can you invert the default here and switch to a method like with_static_head
?
The diff here is also very large and touches a lot of unrelated files. I'm guessing you have a different clippy config than we use. Can you revert those changes?
Yeah, I have a different config showing 200 warnings for |
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
935d512
to
f6c56a2
Compare
The first commit implements a solution to #4644.
The others are lints applied by
clippy
.