Skip to content

Conversation

omar-mohamed-khallaf
Copy link
Contributor

@omar-mohamed-khallaf omar-mohamed-khallaf commented Sep 9, 2025

The first commit implements a solution to #4644.
The others are lints applied by clippy.

@omar-mohamed-khallaf omar-mohamed-khallaf requested a review from a team as a code owner September 9, 2025 09:31
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An option to inject stylesheets and scripts at compile time into the head would be great, but I don't think it should be the default. manganis is built to work across libraries and this doesn't seem like a good default for libraries. Adding dioxus-components should not inject the stylesheet into the head for components I don't use automatically

Can you invert the default here and switch to a method like with_static_head?

The diff here is also very large and touches a lot of unrelated files. I'm guessing you have a different clippy config than we use. Can you revert those changes?

@omar-mohamed-khallaf
Copy link
Contributor Author

Yeah, I have a different config showing 200 warnings for request.rs alone, so I nuked the whole crate with cargo clippy --fix -- -Wclippy::all -Dclippy::correctness -Wclippy::pedantic.

Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf omar-mohamed-khallaf force-pushed the feat/eager-loading-of-assets branch from 935d512 to f6c56a2 Compare September 20, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants