Add exponential backoff setting for retries when an extractor fails to extract or insert anything#276
Open
jpenilla wants to merge 2 commits intoDirewolf20-MC:mainfrom
Open
Add exponential backoff setting for retries when an extractor fails to extract or insert anything#276jpenilla wants to merge 2 commits intoDirewolf20-MC:mainfrom
jpenilla wants to merge 2 commits intoDirewolf20-MC:mainfrom
Conversation
jpenilla
force-pushed
the
exponential-backoff
branch
from
085d097 to
8c43865
Compare
…o extract or insert anything In some cases we need to move large amounts of items/fluids/etc. very quickly, but only in bursts (not constantly/all the time). By enabling backoff we can accomplish this with less of a tps hit on average.
jpenilla
force-pushed
the
exponential-backoff
branch
from
8c43865 to
bcd0b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases we need to move large amounts of items/fluids/etc. very quickly, but only in bursts (not constantly/all the time).
By enabling backoff we can accomplish this with less of a tps hit on average.
I haven't added this to the GUI for energy extractors yet as external inventories/fluid containers tend to be much bigger lag contributors than energy, but if this concept is something the maintainers want to move forward with I can finish that TODO as well.
For reference, AE2 does something very similar with formation planes (albeit by default with no option), and I'm sure other mods also implement similar ideas.
In the following example, the item card is set to a maximum backoff of 2^3. This means that on each failure or success, the card will increment or decrement the power of 2 used between 0 (2^0 * 4, 4 ticks, normal delay) and 3 (2^3 * 4 ticks, or 32 ticks after 3 successive failures).
