ENG-1551 - Fixing "Serverless function has exceeded ..." by mdroidian · Pull Request #927 · DiscourseGraphs/discourse-graph

mdroidian · 2026-03-30T01:41:27Z

Introduced a new blogDirectory.ts file to centralize the blog directory path management.
Updated readBlogs.tsx and page.tsx to import and use BLOG_DIRECTORY instead of the previously hardcoded BLOG_PATH.
Removed the BLOG_PATH constant from constants.ts to streamline the codebase.

" Root cause was the blog filesystem lookup used by / and /blog. It was resolving the blog directory from process.cwd(), which made Next/Vercel’s file tracer over-approximate the dependency set and pull in most of apps/website/.next including webpack cache packs, plus all of apps/website/public. That matches your Vercel log: .next ~228.5 MB + public ~49 MB, and it also explains why a redeploy sometimes passes, since the .next/cache contents vary between builds."

"...the home/blog traces dropped from roughly 573 MB each to about 1.8 MB, which is exactly the Vercel issue we were trying to eliminate."

Summary by CodeRabbit

Refactor
- Refactored blog directory path resolution for improved modularity and consistency.

- Introduced a new blogDirectory.ts file to centralize the blog directory path management. - Updated readBlogs.tsx and page.tsx to import and use BLOG_DIRECTORY instead of the previously hardcoded BLOG_PATH. - Removed the BLOG_PATH constant from constants.ts to streamline the codebase.

linear · 2026-03-30T01:41:31Z

ENG-1551 Fixing "Serverless function has exceeded ..."

supabase · 2026-03-30T01:41:36Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

mdroidian · 2026-03-30T01:45:01Z

@coderabbitai full review

coderabbitai · 2026-03-30T01:45:07Z

✅ Actions performed

Full review triggered.

devin-ai-integration

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

apps/website/app/(home)/blog/blogDirectory.ts

coderabbitai · 2026-03-30T01:50:58Z

📝 Walkthrough

Walkthrough

This PR refactors blog directory path resolution by introducing a new module that computes the blog directory path using import.meta.url, replacing the previous approach of using a string constant BLOG_PATH that required runtime path resolution. The new centralized BLOG_DIRECTORY export is then imported across blog-related files.

Changes

Cohort / File(s)	Summary
Blog Directory Path Centralization `apps/website/app/(home)/blog/blogDirectory.ts`	New module that derives the blog directory path from `import.meta.url` and exports `BLOG_DIRECTORY` as the computed path to the `posts` subdirectory.
Blog Utilities Updated `apps/website/app/(home)/blog/page.tsx`, `apps/website/app/(home)/blog/readBlogs.tsx`	Updated imports to use the new `BLOG_DIRECTORY` from `blogDirectory.ts` instead of the `BLOG_PATH` constant from `~/data/constants`. Removed unused `path` import from page.tsx.
Constants Cleanup `apps/website/app/data/constants.ts`	Removed the exported `BLOG_PATH` constant that is no longer needed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

ENG-437 Remove Error from Blog Build (Closes #71) #203: Modifies blog page's generateStaticParams and file-metadata usage alongside similar blog directory handling refactoring.
Website: Refactor Blog Utils into General Utils #66: Updates the same files (page.tsx, readBlogs.tsx, constants.ts) for blog directory path handling and may have overlapping changes.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title references a specific issue (ENG-1551) and mentions fixing a serverless function error, but does not clearly convey the actual change: centralizing blog directory path management to resolve the issue.	Consider a more specific title like 'Refactor blog directory path to centralize configuration and fix serverless timeout' to better describe the actual implementation.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

apps/website/app/(home)/blog/blogDirectory.ts (1)
1-9: Consider using new URL() pattern for more robust file path resolution.

The current implementation using fileURLToPath(import.meta.url) works correctly in Next.js 15 and Turbopack. However, the more robust pattern for file path resolution is new URL('./relative-path', import.meta.url).pathname, which explicitly constructs a file URL and is more resilient to bundler transformations.

If you prefer stronger type safety and consistency with modern ESM patterns, consider refactoring to:
Suggested refactor
import path from "node:path";

const BLOG_MODULE_PATH = new URL(".", import.meta.url).pathname;

export const BLOG_DIRECTORY = path.join(BLOG_MODULE_PATH, "posts");
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/website/app/`(home)/blog/blogDirectory.ts around lines 1 - 9, Replace
the fileURLToPath(import.meta.url) approach with the new URL(...) pattern for
more robust ESM path resolution: update the BLOG_MODULE_PATH initialization to
use new URL(".", import.meta.url).pathname, remove the unused fileURLToPath
import, and keep BLOG_DIRECTORY built via path.join(BLOG_MODULE_PATH, "posts")
so that BLOG_MODULE_PATH and BLOG_DIRECTORY use the new URL-based pathname
resolution.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/website/app/`(home)/blog/blogDirectory.ts:
- Around line 1-9: Replace the fileURLToPath(import.meta.url) approach with the
new URL(...) pattern for more robust ESM path resolution: update the
BLOG_MODULE_PATH initialization to use new URL(".", import.meta.url).pathname,
remove the unused fileURLToPath import, and keep BLOG_DIRECTORY built via
path.join(BLOG_MODULE_PATH, "posts") so that BLOG_MODULE_PATH and BLOG_DIRECTORY
use the new URL-based pathname resolution.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f8071cc0-f673-4e38-9787-62d9f84c136c

📥 Commits

Reviewing files that changed from the base of the PR and between baaa863 and c3c8219.

📒 Files selected for processing (4)

apps/website/app/(home)/blog/[slug]/page.tsx
apps/website/app/(home)/blog/blogDirectory.ts
apps/website/app/(home)/blog/readBlogs.tsx
apps/website/app/data/constants.ts

💤 Files with no reviewable changes (1)

apps/website/app/data/constants.ts

devin-ai-integration bot reviewed Mar 30, 2026

View reviewed changes

apps/website/app/(home)/blog/blogDirectory.ts Show resolved Hide resolved

coderabbitai bot reviewed Mar 30, 2026

View reviewed changes

mdroidian merged commit 69bf42c into main Mar 30, 2026
8 checks passed

mdroidian deleted the eng-1551-fixing-serverless-function-has-exceeded branch March 30, 2026 01:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENG-1551 - Fixing "Serverless function has exceeded ..."#927

ENG-1551 - Fixing "Serverless function has exceeded ..."#927
mdroidian merged 1 commit intomainfrom
eng-1551-fixing-serverless-function-has-exceeded

mdroidian commented Mar 30, 2026 •

edited

Loading

Uh oh!

linear bot commented Mar 30, 2026

Uh oh!

supabase bot commented Mar 30, 2026

Uh oh!

mdroidian commented Mar 30, 2026

Uh oh!

coderabbitai bot commented Mar 30, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

coderabbitai bot commented Mar 30, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mdroidian commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear bot commented Mar 30, 2026

Uh oh!

supabase bot commented Mar 30, 2026

Uh oh!

mdroidian commented Mar 30, 2026

Uh oh!

coderabbitai bot commented Mar 30, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mdroidian commented Mar 30, 2026 •

edited

Loading

coderabbitai bot commented Mar 30, 2026 •

edited

Loading