Implemented Multi-Signature Wallet Support#451
Merged
truthixify merged 8 commits intoDistinctCodes:mainfrom Jan 30, 2026
Merged
Implemented Multi-Signature Wallet Support#451truthixify merged 8 commits intoDistinctCodes:mainfrom
truthixify merged 8 commits intoDistinctCodes:mainfrom
Conversation
|
@Sandijigs is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
- Add missing Ledger trait import to access_control_tests - Remove unused mut keywords on admins and ms_config variables - Add clippy allow attribute for update_multisig_config_full function
- Import LedgerInfo from soroban_sdk::testutils instead of soroban_sdk::ledger - Update all LedgerInfo references to use the correct import
Remove unnecessary reference operators for generic args in contains() calls
…l version - Add time advancement past time-lock for critical proposals (AddAdmin, BatchBlacklist, Pause) - Fix protocol version from 20 to 22 to resolve InternalError - Critical proposals require both critical_threshold AND time-lock to pass before execution
Previous version 22 was still too old for the host
Contributor
Author
|
Hi @truthixify , please help review and merge , All conflict has been resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the access control system with advanced multi-signature operations for critical administrative functions, significantly improving security for high-value operations.
fixes issue #425
Changes Made
Files Modified
contracts/access_control/src/types.rs- Added ProposalType enum, enhanced MultiSigConfig and PendingProposal structurescontracts/access_control/src/errors.rs- Added 18 multisig-specific error codescontracts/access_control/src/access_control.rs- Implemented enhanced proposal workflow with 10+ new functionscontracts/access_control/src/lib.rs- Added 9 new public endpointscontracts/access_control/src/access_control_tests.rs- Added 20+ comprehensive test casescontracts/manage_hub/src/lib.rs- Added integration documentationKey Features
✅ Tiered signature thresholds (2/3/4 for standard/critical/emergency operations)
✅ Time-locked critical operations with configurable delays
✅ Emergency mode with highest approval requirements
✅ Proposal rejection mechanism with auto-rejection threshold
✅ Comprehensive statistics tracking (created/executed/rejected/expired)
✅ Automatic cleanup of expired proposals
Testing
Security Improvements
Example Usage
Closes #425