check if for loop parameters are reused incorrectly#19
Open
mardaravicius wants to merge 1 commit intoDivy1211:mainfrom
Open
check if for loop parameters are reused incorrectly#19mardaravicius wants to merge 1 commit intoDivy1211:mainfrom
mardaravicius wants to merge 1 commit intoDivy1211:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempt to fix the issue:
#16
added tests that check for various cases though not sure if i put the tests in the right place.
it works by introducing an active_loop_params map in the FnInfo that keeps track which for loop params are defined.
it seems that only for loop params are scoped in any way as all the other variables are either global or entire function scope.
there are many cases when for loop param can be reused or not. added tests to as many as i could think of