Open
Conversation
Contributor
Boburm1rzo
commented
Mar 22, 2025
Boburm1rzo
commented
Ramadan1011
requested changes
Mar 22, 2025
Comment on lines
+104
to
+117
| [HttpGet] | ||
| public async Task<IActionResult> CheckUserName(string userName, int? id = null) | ||
| { | ||
| if (string.IsNullOrEmpty(userName)) | ||
| { | ||
| return Json(new { isTaken = false }); | ||
| } | ||
|
|
||
| var employees = await employeeStore.GetAsync(); | ||
| var isTaken = employees.Any(x => x.UserName.ToLower() == userName.ToLower() && (id == null || x.Id != id)); | ||
|
|
||
| return Json(new { isTaken }); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think this is a very good change
and we should apply this in many cases ( phone number, passport, etc. )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.